linux-kernel - Re: [PATCH 30/34] sata: mv: drop unnecessary #ifdef checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zg0dGmVC9AFYY_RH@smile.fi.intel.com>
Date: Wed, 3 Apr 2024 12:10:50 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: linux-kernel@...r.kernel.org, Damien Le Moal <dlemoal@...nel.org>,
	Niklas Cassel <cassel@...nel.org>,
	Saeed Bishara <saeed@...ntu-saeed.il.marvell.com>,
	Arnd Bergmann <arnd@...db.de>, Ma Ke <make_ruc2021@....com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Sergey Shtylyov <s.shtylyov@....ru>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Jeff Garzik <jeff@...zik.org>, linux-ide@...r.kernel.org
Subject: Re: [PATCH 30/34] sata: mv: drop unnecessary #ifdef checks

On Wed, Apr 03, 2024 at 10:06:48AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Building with W=1 shows a warning for an unused variable when CONFIG_PCI
> is diabled:
> 
> drivers/ata/sata_mv.c:790:35: error: unused variable 'mv_pci_tbl' [-Werror,-Wunused-const-variable]
> static const struct pci_device_id mv_pci_tbl[] = {
> 
> Move the table into the same block that containsn the pci_driver
> definition.

..

> +	{ }			/* terminate list */
> +};

> +

Too many blank lines now.

>  
>  static struct pci_driver mv_pci_driver = {
>  	.name			= DRV_NAME,

-- 
With Best Regards,
Andy Shevchenko