linux-kernel - Re: [PATCH 1/2] selftests: break the dependency upon local header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 4 Apr 2024 20:45:37 +0200
From: David Hildenbrand <david@...hat.com>
To: John Hubbard <jhubbard@...dia.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: Peter Xu <peterx@...hat.com>, Shuah Khan <shuah@...nel.org>,
 Axel Rasmussen <axelrasmussen@...gle.com>,
 Andrea Arcangeli <aarcange@...hat.com>, linux-mm@...ck.org,
 linux-kselftest@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Mark Brown <broonie@...nel.org>,
 Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Suren Baghdasaryan <surenb@...gle.com>, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 1/2] selftests: break the dependency upon local header
 files

On 28.03.24 04:34, John Hubbard wrote:
> Use tools/include/uapi/ files instead. These are obtained by taking a
> snapshot: run "make headers" at the top level, then copy the desired
> header file into the appropriate subdir in tools/uapi/.
> 
> This was discussed and solved in [1].
> 
> However, even before copying any additional files there, there are
> already quite a few in tools/include/uapi already. And these will
> immediately fix a number of selftests/mm build failures.
> 
> So this patch:
> 
> a) Adds TOOLS_INCLUDES to selftests/lib.mk, so that all selftests can
> immediately and easily include the snapshotted header files.
> 
> b) Uses $(TOOLS_INCLUDES) in the selftests/mm build. On today's Arch
> Linux, this already fixes all build errors except for a few
> userfaultfd.h (those will be addressed in a subsequent patch).
> 
> [1] https://lore.kernel.org/all/783a4178-1dec-4e30-989a-5174b8176b09@redhat.com/
> 
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>
> Cc: Suren Baghdasaryan <surenb@...gle.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---
>

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb