linux-kernel - Re: [PATCH 0/2] Fix selftests/mm build without requiring "make headers"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <834542e1-bb29-49ed-98ee-13a79168819f@nvidia.com>
Date: Thu, 28 Mar 2024 10:28:38 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>
Cc: David Hildenbrand <david@...hat.com>, Peter Xu <peterx@...hat.com>,
 Axel Rasmussen <axelrasmussen@...gle.com>,
 Andrea Arcangeli <aarcange@...hat.com>, linux-mm@...ck.org,
 linux-kselftest@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Mark Brown <broonie@...nel.org>, Suren Baghdasaryan <surenb@...gle.com>,
 Peter Zijlstra <peterz@...radead.org>, Guillaume Tucker <gtucker@...cker.io>
Subject: Re: [PATCH 0/2] Fix selftests/mm build without requiring "make
 headers"

On 3/28/24 2:02 AM, Muhammad Usama Anjum wrote:
> On 3/28/24 8:34 AM, John Hubbard wrote:
>> Hi,
>>
>> As mentioned in each patch, this implements the solution that we discussed in
>> December 2023, in [1]. This turned out to be very clean and easy. It should also
>> be quite easy to maintain.
> There is another way. The headers should be built automatically by make
> dependency. The topmost make file always builds headers before building
> kselftest i.e., make kselftest
> 

I think we talked through this already: Peter Z. pointed out the problems
with requiring this kind of prerequisite. And it really it overkill. The
approach here is simple, easy to maintain, and avoids breaking the various
unusual build setups that people have.

I'll shut up now and let others weigh in, though. :)


thanks,
-- 
John Hubbard
NVIDIA