linux-kernel - Re: [PATCH v2 1/3] ARM: dts: Modify GPIO table for Asrock X570D4U BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 04 Apr 2024 11:47:38 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Renze Nicolai <renze@...lus.nl>, linux-arm-kernel@...ts.infradead.org, 
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-aspeed@...ts.ozlabs.org, arnd@...db.de, olof@...om.net,
 soc@...nel.org,  robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 joel@....id.au,  andrew@...id.au
Subject: Re: [PATCH v2 1/3] ARM: dts: Modify GPIO table for Asrock X570D4U
 BMC

Hi Renze,

In the future, the start of the subject should also include 'aspeed: ',
so:

    ARM: dts: aspeed: Modify GPIO table for Asrock X570D4U BMC

On Wed, 2024-04-03 at 15:28 +0200, Renze Nicolai wrote:
> Restructure GPIO table to fit maximum line length.
> 
> Fix mistakes found while working on OpenBMC
> userland configuration and based on probing
> the board.
> 
> Schematic for this board is not available.
> Because of this the choice was made to
> use a descriptive method for naming the
> GPIOs.
> 
>  - Push-pull outputs start with output-*
>  - Open-drain outputs start with control-*
>  - LED outputs start with led-*
>  - Inputs start with input-*
>  - Button inputs start with button-*
>  - Active low signals end with *-n

This seems to be a bit of a mix of following conventions in [1] and
not. It might be helpful to weigh in on that document with your ideas.

[1]: https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md

I'll put this series in a tree for Joel for now though, with the
subject fix mentioned above.

I've also re-wrapped the commit messages as it seems you stopped a bit
short of the allowable line length.

Andrew