linux-kernel - Re: [PATCH] mm/slab_common: Modify mismatched function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 3 Apr 2024 18:23:20 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
 iamjoonsoo.kim@....com, vbabka@...e.cz, roman.gushchin@...ux.dev,
 42.hyeyoo@...il.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 Abaci Robot <abaci@...ux.alibaba.com>, Suren Baghdasaryan
 <surenb@...gle.com>, Kent Overstreet <kent.overstreet@...ux.dev>
Subject: Re: [PATCH] mm/slab_common: Modify mismatched function name

On Thu, 28 Mar 2024 10:07:11 +0800 Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote:

> No functional modification involved.
> 
> mm/slab_common.c:1215: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead.
> 
> ...
>
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1199,7 +1199,7 @@ __do_krealloc(const void *p, size_t new_size, gfp_t flags)
>  }
>  
>  /**
> - * krealloc - reallocate memory. The contents will remain unchanged.
> + * krealloc_noprof - reallocate memory. The contents will remain unchanged.
>   * @p: object to reallocate memory for.
>   * @new_size: how many bytes of memory are required.
>   * @flags: the type of memory to allocate.

Well ok, but krealloc_noprof() is just an internal implementation
detail.  I suggest this documentation be moved to the new krealloc()
wrapper site.  Because krealloc() remains the thing which people
actually call.

Presumably the same applies to more of the new _noprof functions.