linux-kernel - RE: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 5 Apr 2024 19:36:09 +0000
From: "Bird, Tim" <Tim.Bird@...y.com>
To: Shuah Khan <skhan@...uxfoundation.org>,
        Muhammad Usama Anjum
	<usama.anjum@...labora.com>,
        Eric Biederman <ebiederm@...ssion.com>,
        Kees
 Cook <keescook@...omium.org>, Shuah Khan <shuah@...nel.org>,
        Andrew Morton
	<akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "kernel@...labora.com" <kernel@...labora.com>
Subject: RE: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in
 ksft_exit_fail_msg()

Sorry I didn't catch this on the original submission.

> -----Original Message-----
> From: Shuah Khan <skhan@...uxfoundation.org>
> 
> On 4/5/24 07: 17, Muhammad Usama Anjum wrote: > "Bail out! " is not descriptive. It rather should be: "Failed: " and > then this added prefix
> doesn't need to be added everywhere. Usually in > the logs, we are searching for "Failed"
> ZjQcmQRYFpfptBannerStart
> Caution : This email originated from outside of Sony.
> Do not click links or open any attachments unless you recognize the sender and know the content is safe. Please report phishing if unsure.
> 
> ZjQcmQRYFpfptBannerEnd
> On 4/5/24 07:17, Muhammad Usama Anjum wrote:
> > "Bail out! " is not descriptive. It rather should be: "Failed: " and
> > then this added prefix doesn't need to be added everywhere. Usually in
> > the logs, we are searching for "Failed" or "Error" instead of "Bail
> > out" so it must be replace.

Bail out! is the wording in the original TAP spec.  We should not change
it unless we plan to abandon compatibility with that spec. (which I
would advise against).

See https://testanything.org/tap-specification.html

The reason "Bail out!" is preferred (IMO) is that it is less likely to be emitted
in other test output, and is more 'grepable'.

This would get a NAK from me.
 -- Tim

> >
> > Remove Error/Failed prefixes from all usages as well.
> >
> > Muhammad Usama Anjum (2):
> >    selftests: Replace "Bail out" with "Error"
> >    selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages
> >
> >   tools/testing/selftests/exec/load_address.c   |   8 +-
> >   .../testing/selftests/exec/recursion-depth.c  |  10 +-
> >   tools/testing/selftests/kselftest.h           |   2 +-
> >   .../selftests/mm/map_fixed_noreplace.c        |  24 +--
> >   tools/testing/selftests/mm/map_populate.c     |   2 +-
> >   tools/testing/selftests/mm/mremap_dontunmap.c |   2 +-
> >   tools/testing/selftests/mm/pagemap_ioctl.c    | 166 +++++++++---------
> >   .../selftests/mm/split_huge_page_test.c       |   2 +-
> >   8 files changed, 108 insertions(+), 108 deletions(-)
> >
> 
> Andrew, Kees,
> 
> I will apply these to linux-kselftest next as a series since these
> changes depend on change to tools/testing/selftests/kselftest.h
> and need to go together.
> 
> Are you okay with that?
> 
> thanks,
> -- Shuah
>