linux-kernel - Re: [PATCH v3 08/10] perf/hisi_uncore: Avoid placing cpumask on the stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240405105441.00006f59@Huawei.com>
Date: Fri, 5 Apr 2024 10:54:41 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Dawei Li <dawei.li@...ngroup.cn>
CC: <will@...nel.org>, <mark.rutland@....com>, <yury.norov@...il.com>,
	<linux@...musvillemoes.dk>, <xueshuai@...ux.alibaba.com>,
	<renyu.zj@...ux.alibaba.com>, <yangyicong@...ilicon.com>,
	<andersson@...nel.org>, <konrad.dybcio@...aro.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v3 08/10] perf/hisi_uncore: Avoid placing cpumask on the
 stack

On Wed, 3 Apr 2024 23:59:48 +0800
Dawei Li <dawei.li@...ngroup.cn> wrote:

> In general it's preferable to avoid placing cpumasks on the stack, as
> for large values of NR_CPUS these can consume significant amounts of
> stack space and make stack overflows more likely.
> 
> Use cpumask_any_and_but() to avoid the need for a temporary cpumask on
> the stack.
> 
> Suggested-by: Mark Rutland <mark.rutland@....com>
> Reviewed-by: Mark Rutland <mark.rutland@....com>
> Signed-off-by: Dawei Li <dawei.li@...ngroup.cn>
Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>