linux-kernel - Re: [PATCH] io_uring: Fix io_cqring_wait() not restoring sigmask on get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b46a5c6f-4bdf-4fbf-bd85-183692ed6453@kernel.dk>
Date: Sat, 6 Apr 2024 06:57:18 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Alexey Izbyshev <izbyshev@...ras.ru>
Cc: Pavel Begunkov <asml.silence@...il.com>,
 Olivier Langlois <olivier@...llion01.com>, io-uring@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] io_uring: Fix io_cqring_wait() not restoring sigmask on
 get_timespec64() failure

On 4/6/24 5:12 AM, Alexey Izbyshev wrote:
> On 2024-04-06 05:06, Jens Axboe wrote:
>> On 4/5/24 6:55 AM, Alexey Izbyshev wrote:
>>> This bug was introduced in commit 950e79dd7313 ("io_uring: minor
>>> io_cqring_wait() optimization"), which was made in preparation for
>>> adc8682ec690 ("io_uring: Add support for napi_busy_poll"). The latter
>>> got reverted in cb3182167325 ("Revert "io_uring: Add support for
>>> napi_busy_poll""), so simply undo the former as well.
>>
>> Thanks - ironically I had to hand apply this one, as some of the
>> commits you mention above are not in the base you used for the
>> patch...
> 
> I used v6.8 as the base, and all three commits mentioned above are
> there. However, the patch indeed doesn't apply to the current tip
> because of post-v6.8 changes, sorry for that!

Not a problem, but it does highlight that this will certainly throw a
reject once stable tries to pick it up. Just something to keep an eye
on.

-- 
Jens Axboe