linux-kernel - Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFhGd8ohK=tQ+_qBQF5iW10qoySWi6MsGNoL3diBGHsgsP+n_A@mail.gmail.com>
Date: Mon, 8 Apr 2024 14:21:10 -0700
From: Justin Stitt <justinstitt@...gle.com>
To: Jan Kara <jack@...e.cz>
Cc: Arnd Bergmann <arnd@...nel.org>, linux-fsdevel@...r.kernel.org, 
	Mike Marshall <hubcap@...ibond.com>, Arnd Bergmann <arnd@...db.de>, 
	Alexander Viro <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>, 
	Martin Brandenburg <martin@...ibond.com>, devel@...ts.orangefs.org, 
	Vlastimil Babka <vbabka@...e.cz>, Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access

On Mon, Apr 8, 2024 at 7:36 AM Jan Kara <jack@...e.cz> wrote:
> Frankly, this initializer is hard to understand for me. Why not simple:
>
>         buf->f_fsid[0] = ORANGEFS_SB(sb)->fs_id;
>         buf->f_fsid[1] = ORANGEFS_SB(sb)->id;
>

+1 for this idea, seems easier to read for me.

>                                                                 Honza
> --
> Jan Kara <jack@...e.com>
> SUSE Labs, CR