linux-kernel - Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <96b55a64-2bcf-44da-a728-ae54e2a73343@app.fastmail.com>
Date: Tue, 09 Apr 2024 07:54:47 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Justin Stitt" <justinstitt@...gle.com>, "Jan Kara" <jack@...e.cz>
Cc: "Arnd Bergmann" <arnd@...nel.org>, linux-fsdevel@...r.kernel.org,
 "Mike Marshall" <hubcap@...ibond.com>,
 "Alexander Viro" <viro@...iv.linux.org.uk>,
 "Christian Brauner" <brauner@...nel.org>,
 "Martin Brandenburg" <martin@...ibond.com>, devel@...ts.orangefs.org,
 "Vlastimil Babka" <vbabka@...e.cz>, "Kees Cook" <keescook@...omium.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access

On Mon, Apr 8, 2024, at 23:21, Justin Stitt wrote:
> On Mon, Apr 8, 2024 at 7:36 AM Jan Kara <jack@...e.cz> wrote:
>> Frankly, this initializer is hard to understand for me. Why not simple:
>>
>>         buf->f_fsid[0] = ORANGEFS_SB(sb)->fs_id;
>>         buf->f_fsid[1] = ORANGEFS_SB(sb)->id;
>>
>
> +1 for this idea, seems easier to read for me.

Yes, good idea, I'll send this as v2 after my next round
of build testing.

      Arnd