linux-kernel - Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Apr 2024 12:26:12 -0400
From: Mike Marshall <hubcap@...ibond.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: Justin Stitt <justinstitt@...gle.com>, Jan Kara <jack@...e.cz>, 
	Arnd Bergmann <arnd@...nel.org>, linux-fsdevel@...r.kernel.org, 
	Alexander Viro <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>, 
	Martin Brandenburg <martin@...ibond.com>, devel@...ts.orangefs.org, 
	Vlastimil Babka <vbabka@...e.cz>, Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org, 
	Mike Marshall <hubcap@...ibond.com>
Subject: Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access

I applied Arnd's patch on top of Linux 6.9-rc3 and
ran through xfstests with no issue.

Also, instead of Arnd's patch, I used Jan's idea:

+
+       buf->f_fsid.val[0] = ORANGEFS_SB(sb)->fs_id;
+       buf->f_fsid.val[1] = ORANGEFS_SB(sb)->id;
+

And ran that through as well, no issue.

Sorry for missing the earlier patch.

-Mike

On Tue, Apr 9, 2024 at 1:55 AM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Mon, Apr 8, 2024, at 23:21, Justin Stitt wrote:
> > On Mon, Apr 8, 2024 at 7:36 AM Jan Kara <jack@...e.cz> wrote:
> >> Frankly, this initializer is hard to understand for me. Why not simple:
> >>
> >>         buf->f_fsid[0] = ORANGEFS_SB(sb)->fs_id;
> >>         buf->f_fsid[1] = ORANGEFS_SB(sb)->id;
> >>
> >
> > +1 for this idea, seems easier to read for me.
>
> Yes, good idea, I'll send this as v2 after my next round
> of build testing.
>
>       Arnd