linux-kernel - Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <03b98c31-130d-4ec7-b162-621bd5b604cf@app.fastmail.com>
Date: Tue, 09 Apr 2024 21:33:48 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Mike Marshall" <hubcap@...ibond.com>
Cc: "Justin Stitt" <justinstitt@...gle.com>, "Jan Kara" <jack@...e.cz>,
 "Arnd Bergmann" <arnd@...nel.org>, linux-fsdevel@...r.kernel.org,
 "Alexander Viro" <viro@...iv.linux.org.uk>,
 "Christian Brauner" <brauner@...nel.org>,
 "Martin Brandenburg" <martin@...ibond.com>, devel@...ts.orangefs.org,
 "Vlastimil Babka" <vbabka@...e.cz>, "Kees Cook" <keescook@...omium.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access

On Tue, Apr 9, 2024, at 18:26, Mike Marshall wrote:
> I applied Arnd's patch on top of Linux 6.9-rc3 and
> ran through xfstests with no issue.
>
> Also, instead of Arnd's patch, I used Jan's idea:
>
> +
> +       buf->f_fsid.val[0] = ORANGEFS_SB(sb)->fs_id;
> +       buf->f_fsid.val[1] = ORANGEFS_SB(sb)->id;
> +
>
> And ran that through as well, no issue.
>
> Sorry for missing the earlier patch.

Thanks!

I was about to send the updated patch and can skip that now.

   Arnd