linux-kernel - Re: [PATCH] selftests: kselftest_harness: Print empty string, not empty fmt on PASS/FAIL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Apr 2024 16:53:22 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kees Cook <keescook@...omium.org>
Cc: Sean Christopherson <seanjc@...gle.com>, Shuah Khan <shuah@...nel.org>,
 Nathan Chancellor <nathan@...nel.org>, linux-kselftest@...r.kernel.org,
 llvm@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: kselftest_harness: Print empty string, not
 empty fmt on PASS/FAIL

On Tue, 9 Apr 2024 16:46:40 -0700 Kees Cook wrote:
> 	ksft_test_result_code(t->exit_code, test_name, "%s",
> 			      diagnostic ?: "");

Could work, but we need to change the callee to extract the first arg
after format from va_arg, which I wasn't sufficiently familiar with :(