[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZhXZ3BEcbtoJKPFM@google.com>
Date: Tue, 9 Apr 2024 17:14:20 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Kees Cook <keescook@...omium.org>, Shuah Khan <shuah@...nel.org>,
Nathan Chancellor <nathan@...nel.org>, linux-kselftest@...r.kernel.org, llvm@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: kselftest_harness: Print empty string, not
empty fmt on PASS/FAIL
On Tue, Apr 09, 2024, Jakub Kicinski wrote:
> On Tue, 9 Apr 2024 15:42:56 -0700 Sean Christopherson wrote:
> > - ksft_test_result_code(t->exit_code, test_name,
> > - diagnostic ? "%s" : "", diagnostic);
> > + ksft_test_result_code(t->exit_code, test_name, "%s", diagnostic);
>
> Have you tested that to make sure it doesn't change the output?
>
> .. warning: ^^ leading question ;)
Heh, I was *this* close to adding a blurb saying this was probably only compile
tested.
Powered by blists - more mailing lists