linux-kernel - Re: [PATCH v2 0/4] HID: Add support for Himax HX83102j touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 10 Apr 2024 10:58:13 +0800
From: Allen Lin <allencl_lin@...mail.com>
To: Jiri Kosina <jikos@...nel.org>
Cc: dmitry.torokhov@...il.com, robh@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor@...nel.org, 
	benjamin.tissoires@...hat.com, linux-input@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] HID: Add support for Himax HX83102j touchscreen

Jiri Kosina <jikos@...nel.org> 於 2024年4月3日 週三 下午7:48寫道：
>
> On Tue, 2 Apr 2024, Allen_Lin wrote:
>
> > Hi,
> > This driver implements for Himax HID touchscreen HX83102j.
> >
> > Using SPI interface to receive/send HID packets.
> >
> > Changes in v2 :
> > -Added power description in YAML document.
> > -Added ddreset-gpios property in YAML document.
> > -Added firmware-name property in YAML document.
> > -Modified the description of pid.
> > -Modified the example.
> >
> > Allen_Lin (4):
> >   dt-bindings: input: Add Himax HX83102J touchscreen
> >   HID: Add Himax HX83102J touchscreen driver
> >   HID: Add DRM panel follower function
> >   HID: Load firmware directly from file to IC
> >
> >  .../input/touchscreen/himax,hx83102j.yaml     |  100 +
> >  MAINTAINERS                                   |    7 +
> >  drivers/hid/Kconfig                           |    7 +
> >  drivers/hid/Makefile                          |    2 +
> >  drivers/hid/hid-himax-83102j.c                | 3071 +++++++++++++++++
> >  drivers/hid/hid-himax-83102j.h                |  460 +++
>
> My only nit here -- could we please call the driver just hid-himax, to
> follow the pattern we generally use in this subsystem (drivers named after
> vendors).
>

83102j is our IC name, we add it to our driver name to distinguish
different ICs,
Can we just reserve this in driver name?

Thanks
Allen

> Please add Ack from Rob, rename the driver, resend, and I'll apply it.
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>