linux-kernel - Re: [PATCH] [v2] scripts/unifdef: avoid constexpr keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Apr 2024 09:52:48 +0200
From: Nicolas Schier <n.schier@....de>
To: Arnd Bergmann <arnd@...nel.org>
Cc: linux-kbuild@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nicolas Schier <nicolas@...sle.eu>, Tony Finch <dot@...at.at>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] scripts/unifdef: avoid constexpr keyword

On Mon, Apr 08, 2024 at 09:17:52AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Starting with c23, 'constexpr' is a keyword in C like in C++ and cannot
> be used as an identifier:
> 
> scripts/unifdef.c:206:25: error: 'constexpr' can only be used in variable declarations
>   206 | static bool             constexpr;              /* constant #if expression */
>       |                         ^
> scripts/unifdef.c:880:13: error: expected identifier or '('
>   880 |                 constexpr = false;
>       |                           ^
> 
> Rename this instance to allow changing to C23 at some point in the future.
> 
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: Nathan Chancellor <nathan@...nel.org>
> Cc: Nicolas Schier <nicolas@...sle.eu>
> Cc: linux-kbuild@...r.kernel.org
> Reviewed-By: Tony Finch <dot@...at.at>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  v2: include fixup from Tony

thanks, LGTM.

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>