linux-kernel - Re: [PATCH v1 11/31] x86/resctrl: Move monitor exit work to a restrl exit call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f919fdc9-e0e3-43ad-979e-024ae0cdd997@intel.com>
Date: Thu, 11 Apr 2024 10:37:27 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Dave Martin <Dave.Martin@....com>
CC: James Morse <james.morse@....com>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>, Fenghua Yu <fenghua.yu@...el.com>, "Thomas
 Gleixner" <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "Borislav
 Petkov" <bp@...en8.de>, H Peter Anvin <hpa@...or.com>, Babu Moger
	<Babu.Moger@....com>, <shameerali.kolothum.thodi@...wei.com>, "D Scott
 Phillips OS" <scott@...amperecomputing.com>, <carl@...amperecomputing.com>,
	<lcherian@...vell.com>, <bobo.shaobowang@...wei.com>,
	<tan.shaopeng@...itsu.com>, <baolin.wang@...ux.alibaba.com>, Jamie Iles
	<quic_jiles@...cinc.com>, Xin Hao <xhao@...ux.alibaba.com>,
	<peternewman@...gle.com>, <dfustini@...libre.com>, <amitsinght@...vell.com>,
	David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>
Subject: Re: [PATCH v1 11/31] x86/resctrl: Move monitor exit work to a restrl
 exit call

Hi Dave,

On 4/11/2024 7:15 AM, Dave Martin wrote:
> On Mon, Apr 08, 2024 at 08:19:00PM -0700, Reinette Chatre wrote:
>> On 3/21/2024 9:50 AM, James Morse wrote:
>>> rdt_put_mon_l3_config() is called via the architecture's
>>> resctrl_arch_exit() call, and appears to free the rmid_ptrs[]
>>> and closid_num_dirty_rmid[] arrays. In reality this code is marked
>>> __exit, and is removed by the linker as resctl can't be built
>>
>> resctl -> resctrl
> 
> Noted, thanks (also, there is "restrl" in the subject line.)

Thank you for catching that.

> 
>>
>>> as a module.
>>>
>>> MPAM can make use of this code from its error interrupt handler,
>>> a later patch drops all the __init/__exit annotations.
>>
>> Reminder:
>> https://lore.kernel.org/lkml/85f8756a-23a0-444e-b37d-a7817b600f46@intel.com/
> 
> The "Drop __init/__exit on assorted symbols" patch speaks for itself,
> I guess. I think it's probably sufficient for now to comfirm that this
> patch is deliberately not changing the annotations for now.
> 
> Does the following work?
> 
> --8<--
> 
> Since there is no immediate need to change them, leave the __exit
> annotations as-is.  This will need to be revisited as and when there is
> a need to call these functions other than at __exit time.
> 
> -->8--

Sounds good. I find a big focus on the __init/__exit annotations
distracting. As I understand this has nothing to do with the goal of
this patch, which is to move code from architecture side to filesystem side. 

Reinette