linux-kernel - Re: [PATCH V4 7/9] tools/arch/x86/intel_sdsi: Fix meter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63c6ec75-324b-2370-94c3-fb95d4d8d754@linux.intel.com>
Date: Thu, 11 Apr 2024 11:52:34 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: "David E. Box" <david.e.box@...ux.intel.com>
cc: Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>, 
    sathyanarayanan.kuppuswamy@...ux.intel.com
Subject: Re: [PATCH V4 7/9] tools/arch/x86/intel_sdsi: Fix meter_certificate
 decoding

On Wed, 10 Apr 2024, David E. Box wrote:

> Fix errors in the calculation of the start position of the counters and in
> the display loop. While here, use a #define for the bundle count and size.
> 
> Fixes: 7fdc03a7370f ("tools/arch/x86: intel_sdsi: Add support for reading meter certificates")
> Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
> ---
> V4 - Use suggested struct bundle_encoding_counter cast
> 
> V3 - Use macros for bundle size and count
> 
> V2 - Split of V1 patch 7
> 
>  tools/arch/x86/intel_sdsi/intel_sdsi.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/arch/x86/intel_sdsi/intel_sdsi.c b/tools/arch/x86/intel_sdsi/intel_sdsi.c
> index ae29214da102..ba2a6b6645ae 100644
> --- a/tools/arch/x86/intel_sdsi/intel_sdsi.c
> +++ b/tools/arch/x86/intel_sdsi/intel_sdsi.c
> @@ -394,7 +394,7 @@ static int sdsi_meter_cert_show(struct sdsi_dev *s)
>  	printf("MMRC encoding:                %.4s\n", name);
>  
>  	printf("MMRC counter:                 %d\n", mc->mmrc_counter);
> -	if (mc->bundle_length % 8) {
> +	if (mc->bundle_length % METER_BUNDLE_SIZE) {
>  		fprintf(stderr, "Invalid bundle length\n");
>  		return -1;
>  	}
> @@ -405,15 +405,16 @@ static int sdsi_meter_cert_show(struct sdsi_dev *s)
>  		return -1;
>  	}
>  
> -	bec = (void *)(mc) + sizeof(mc);
> +	bec = (struct bundle_encoding_counter *)(mc + 1);
>  
>  	printf("Number of Feature Counters:   %ld\n", BUNDLE_COUNT(mc->bundle_length));
> -	while (count++ < mc->bundle_length / 8) {
> +	while (count < BUNDLE_COUNT(mc->bundle_length)) {
>  		char feature[5];
>  
>  		feature[4] = '\0';
>  		get_feature(bec[count].encoding, feature);
>  		printf("    %s:          %d\n", feature, bec[count].counter);
> +		++count;
>  	}
>  
>  	return 0;
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.