linux-kernel - Re: [PATCH V4 8/9] platform/x86/intel/sdsi: Simplify ascii printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <626fd010-aa6e-2963-5860-658b6069e035@linux.intel.com>
Date: Thu, 11 Apr 2024 16:25:50 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: "David E. Box" <david.e.box@...ux.intel.com>
cc: Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>, 
    sathyanarayanan.kuppuswamy@...ux.intel.com
Subject: Re: [PATCH V4 8/9] platform/x86/intel/sdsi: Simplify ascii
 printing

On Thu, 11 Apr 2024, Ilpo Järvinen wrote:

> On Wed, 10 Apr 2024, David E. Box wrote:
> 
> > Add #define for feature length and move NUL assignment from callers to
> > get_feature().
> > 
> > Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
> > Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
> > ---
> > V4 - Move NUL assignment to get_feature() and increment FEAT_LEN.
> > 
> > V3 - Add FEAT_LEN #def
> > 
> > V2 - Split of V1 patch 7
> > 
> >  tools/arch/x86/intel_sdsi/intel_sdsi.c | 17 ++++++++---------
> >  1 file changed, 8 insertions(+), 9 deletions(-)
> > 
> > diff --git a/tools/arch/x86/intel_sdsi/intel_sdsi.c b/tools/arch/x86/intel_sdsi/intel_sdsi.c
> > index ba2a6b6645ae..301213370740 100644
> > --- a/tools/arch/x86/intel_sdsi/intel_sdsi.c
> > +++ b/tools/arch/x86/intel_sdsi/intel_sdsi.c
> > @@ -43,6 +43,7 @@
> >  #define METER_CERT_MAX_SIZE	4096
> >  #define STATE_MAX_NUM_LICENSES	16
> >  #define STATE_MAX_NUM_IN_BUNDLE	(uint32_t)8
> > +#define FEAT_LEN		5	/* 4 plus NUL terminator */
> >  
> >  #define __round_mask(x, y) ((__typeof__(x))((y) - 1))
> >  #define round_up(x, y) ((((x) - 1) | __round_mask(x, y)) + 1)
> > @@ -321,10 +322,11 @@ static char *content_type(uint32_t type)
> >  	}
> >  }
> >  
> > -static void get_feature(uint32_t encoding, char *feature)
> > +static void get_feature(uint32_t encoding, char feature[5])
> >  {
> >  	char *name = (char *)&encoding;
> >  
> > +	feature[4] = '\0';
> >  	feature[3] = name[0];
> >  	feature[2] = name[1];
> >  	feature[1] = name[2];
> 
> Works, assuming none of the name bytes are 0.

Before somebody starts to wonder, while writing that, I thought this patch 
was also about alignment (were <4 chars would have mattered), which was 
just wrong recollection from my part and related to some other patch in 
this series.

> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.