linux-kernel - Re: [PATCH v2 2/2] sched/topology: Optimize topology_span

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhlEVoW6FJC6uBVE@smile.fi.intel.com>
Date: Fri, 12 Apr 2024 17:25:26 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Kyle Meyer <kyle.meyer@....com>
Cc: linux-kernel@...r.kernel.org, yury.norov@...il.com,
	linux@...musvillemoes.dk, mingo@...hat.com, peterz@...radead.org,
	juri.lelli@...hat.com, vincent.guittot@...aro.org,
	dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
	mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
	russ.anderson@....com, dimitri.sivanich@....com, steve.wahl@....com
Subject: Re: [PATCH v2 2/2] sched/topology: Optimize topology_span_sane()

On Thu, Apr 11, 2024 at 04:55:11PM -0500, Kyle Meyer wrote:
> On Thu, Apr 11, 2024 at 01:38:46PM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 10, 2024 at 04:33:11PM -0500, Kyle Meyer wrote:

..

> > > Since topology_span_sane() is called inside of for_each_cpu(), each
> > > pervious CPU has already been compared against every other CPU. The
> > 
> > previous
> 
> Thank you for pointing that out. Should I send an updated version or can
> a maintainer correct my mistake?

Depends on the maintainer. I'm not the one here, don't expect answer from me.

> > > current CPU only needs to be compared against higher-numbered CPUs.

-- 
With Best Regards,
Andy Shevchenko