linux-kernel - Re: [PATCH v2 2/2] sched/topology: Optimize topology_span

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhrD6NLFU1X6F/74@yury-ThinkPad>
Date: Sat, 13 Apr 2024 10:42:07 -0700
From: Yury Norov <yury.norov@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Kyle Meyer <kyle.meyer@....com>, linux-kernel@...r.kernel.org,
	linux@...musvillemoes.dk, mingo@...hat.com, peterz@...radead.org,
	juri.lelli@...hat.com, vincent.guittot@...aro.org,
	dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
	mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
	russ.anderson@....com, dimitri.sivanich@....com, steve.wahl@....com
Subject: Re: [PATCH v2 2/2] sched/topology: Optimize topology_span_sane()

On Fri, Apr 12, 2024 at 05:25:26PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 11, 2024 at 04:55:11PM -0500, Kyle Meyer wrote:
> > On Thu, Apr 11, 2024 at 01:38:46PM +0300, Andy Shevchenko wrote:
> > > On Wed, Apr 10, 2024 at 04:33:11PM -0500, Kyle Meyer wrote:
> 
> ...
> 
> > > > Since topology_span_sane() is called inside of for_each_cpu(), each
> > > > pervious CPU has already been compared against every other CPU. The
> > > 
> > > previous
> > 
> > Thank you for pointing that out. Should I send an updated version or can
> > a maintainer correct my mistake?
> 
> Depends on the maintainer. I'm not the one here, don't expect answer from me.

I like this rework, and I'll take it in bitmap-for-next for testing.

I see Vincent already acked it, so I can also move it upstream, if no
objections from Peter, Juri and Ingo.

Thanks,
Yury