linux-kernel - Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zhldd6D7ts_QJ7rt@black.fi.intel.com>
Date: Fri, 12 Apr 2024 19:12:39 +0300
From: Raag Jadav <raag.jadav@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com,
	linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels

On Fri, Apr 12, 2024 at 06:45:48PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 12, 2024 at 06:38:24PM +0300, Raag Jadav wrote:
> > On Fri, Apr 12, 2024 at 01:12:48PM +0200, Uwe Kleine-König wrote:
> > > On Fri, Apr 12, 2024 at 11:38:12AM +0530, Raag Jadav wrote:
> 
> ...
> 
> > > Otherwise I (only slightly) dislike
> > > > +	struct dwc_pwm_drvdata *data;
> > > because "data" is very generic. I'd call it ddata. But I don't feel
> > > strong here. I'm happy if you change to "ddata" in v2, I will silently
> > > apply anyhow if you prefer "data".
> > 
> > I think "data" is more readable, something like "ddata" would make me
> > re-adjust my glasses ;)
> 
> ddata is _kinda_ idiomatic, there at least several drivers use this name
> (as of my knowledge). I am bending towards Uwe's suggestion here.

Will update in v2.

Raag
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>