linux-kernel - Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhleDwUJLDEG5QwH@black.fi.intel.com>
Date: Fri, 12 Apr 2024 19:15:11 +0300
From: Raag Jadav <raag.jadav@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: u.kleine-koenig@...gutronix.de, jarkko.nikula@...ux.intel.com,
	mika.westerberg@...ux.intel.com, linux-pwm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels

On Fri, Apr 12, 2024 at 06:35:51PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 12, 2024 at 11:38:12AM +0530, Raag Jadav wrote:
> > With 16 channel pwm support, we're registering two instances of pwm_chip
> > with 8 channels each. We need to update PM functions to use both instances
> > of pwm_chip during power state transitions.
> > 
> > Introduce struct dwc_pwm_drvdata and use it as driver_data, which will
> > maintain both instances of pwm_chip along with dwc_pwm_info and allow us
> > to use them inside suspend/resume handles.
> 
> ...
> 
> > +	data = devm_kzalloc(dev, struct_size(data, chips, info->nr), GFP_KERNEL);
> > +	if (!data)
> > +		return dev_err_probe(dev, -ENOMEM, "Failed to allocate drvdata\n");
> 
> Haven't noticed before, but we do not print messages for -ENOMEM. Just return
> the code.

Any special case for -ENOMEM?
I found a few drivers which still do.

Raag