linux-kernel - Re: [PATCH 4.19 000/175] 4.19.312-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87edbaz6vs.ffs@tglx>
Date: Fri, 12 Apr 2024 22:02:47 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Pavel Machek <pavel@...x.de>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>
Cc: stable@...r.kernel.org, patches@...ts.linux.dev,
 linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
 akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
 patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
 jonathanh@...dia.com, f.fainelli@...il.com, sudipm.mukherjee@...il.com,
 srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
 allen.lkml@...il.com, broonie@...nel.org, maco@...roid.com,
 christophe.jaillet@...adoo.fr, sean.anderson@...ux.dev
Subject: Re: [PATCH 4.19 000/175] 4.19.312-rc1 review

On Fri, Apr 12 2024 at 21:46, Pavel Machek wrote:
>> Thomas Gleixner <tglx@...utronix.de>
>>     timers: Move clearing of base::timer_running under base:: Lock
>
> AFAICT, we don't have those NULL assignments in expire_timers in
> 4.19. Can someone doublecheck this? We also don't support PREEMPT_RT
> there.

This has nothing to do with RT.

But yes, 4.19 has the original bass::running_timer clearing which
happens at the end of handling all expired timer callbacks and that
actually happens with base->lock held.

So right, 4.19 is not affected by this.

Thanks,

        tglx