linux-kernel - Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 12 Apr 2024 21:06:19 +0100
From: Calum Mackay <calum.mackay@...cle.com>
To: Chuck Lever III <chuck.lever@...cle.com>,
        Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: Calum Mackay <calum.mackay@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-stable <stable@...r.kernel.org>,
        "patches@...ts.linux.dev" <patches@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Guenter Roeck
 <linux@...ck-us.net>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "patches@...nelci.org" <patches@...nelci.org>,
        "lkft-triage@...ts.linaro.org" <lkft-triage@...ts.linaro.org>,
        "pavel@...x.de" <pavel@...x.de>,
        "jonathanh@...dia.com"
 <jonathanh@...dia.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "sudipm.mukherjee@...il.com" <sudipm.mukherjee@...il.com>,
        "srw@...dewatkins.net" <srw@...dewatkins.net>,
        "rwarsow@....de" <rwarsow@....de>,
        "conor@...nel.org" <conor@...nel.org>,
        "allen.lkml@...il.com" <allen.lkml@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        Vegard Nossum <vegard.nossum@...cle.com>,
        Darren Kenny <darren.kenny@...cle.com>,
        Ramanan Govindarajan <ramanan.govindarajan@...cle.com>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On 12/04/2024 4:57 pm, Chuck Lever III wrote:
> 
> 
>> On Apr 12, 2024, at 6:25 AM, Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com> wrote:
>>
>> Hi Greg,
>>
>>
>> On 11/04/24 15:27, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 5.15.155 release.
>>> There are 57 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>> Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
>>> Anything received after that time might be too late.
>>
>> I have noticed a regression in lts test case with nfsv4 and this was overlooked in the previous cycle(5.15.154). So the regression is from 153-->154 update. And I think that is due to nfs backports we had in 5.15.154.
>>
>> # ./runltp -d /tmpdir -s fcntl17
>>
>> <<<test_start>>>
>> tag=fcntl17 stime=1712915065
>> cmdline="fcntl17"
>> contacts=""
>> analysis=exit
>> <<<test_output>>>
>> fcntl17     0  TINFO  :  Enter preparation phase
>> fcntl17     0  TINFO  :  Exit preparation phase
>> fcntl17     0  TINFO  :  Enter block 1
>> fcntl17     0  TINFO  :  child 1 starting
>> fcntl17     0  TINFO  :  child 1 pid 22904 locked
>> fcntl17     0  TINFO  :  child 2 starting
>> fcntl17     0  TINFO  :  child 2 pid 22905 locked
>> fcntl17     0  TINFO  :  child 3 starting
>> fcntl17     0  TINFO  :  child 3 pid 22906 locked
>> fcntl17     0  TINFO  :  child 2 resuming
>> fcntl17     0  TINFO  :  child 3 resuming
>> fcntl17     0  TINFO  :  child 1 resuming
>> fcntl17     0  TINFO  :  child 3 lockw err 35
>> fcntl17     0  TINFO  :  child 3 exiting
>> fcntl17     0  TINFO  :  child 1 unlocked
>> fcntl17     0  TINFO  :  child 1 exiting
>> fcntl17     1  TFAIL  :  fcntl17.c:429: Alarm expired, deadlock not detected
>> fcntl17     0  TWARN  :  fcntl17.c:430: You may need to kill child processes by hand
>> fcntl17     2  TPASS  :  Block 1 PASSED
>> fcntl17     0  TINFO  :  Exit block 1
>> fcntl17     0  TWARN  :  tst_tmpdir.c:342: tst_rmdir: rmobj(/tmpdir/ltp-jRFBtBQhhx/LTP_fcnp7lqPn) failed: unlink(/tmpdir/ltp-jRFBtBQhhx/LTP_fcnp7lqPn) failed; errno=2: ENOENT
>> <<<execution_status>>>
>> initiation_status="ok"
>> duration=10 termination_type=exited termination_id=5 corefile=no
>> cutime=0 cstime=0
>> <<<test_end>>>
>> <<<test_start>>>
>> tag=fcntl17_64 stime=1712915075
>> cmdline="fcntl17_64"
>> contacts=""
>> analysis=exit
>> <<<test_output>>>
>> incrementing stop
>> fcntl17     0  TINFO  :  Enter preparation phase
>> fcntl17     0  TINFO  :  Exit preparation phase
>> fcntl17     0  TINFO  :  Enter block 1
>> fcntl17     0  TINFO  :  child 1 starting
>> fcntl17     0  TINFO  :  child 1 pid 22909 locked
>> fcntl17     0  TINFO  :  child 2 starting
>> fcntl17     0  TINFO  :  child 2 pid 22910 locked
>> fcntl17     0  TINFO  :  child 3 starting
>> fcntl17     0  TINFO  :  child 3 pid 22911 locked
>> fcntl17     0  TINFO  :  child 2 resuming
>> fcntl17     0  TINFO  :  child 3 resuming
>> fcntl17     0  TINFO  :  child 1 resuming
>> fcntl17     0  TINFO  :  child 3 lockw err 35
>> fcntl17     0  TINFO  :  child 3 exiting
>> fcntl17     0  TINFO  :  child 1 unlocked
>> fcntl17     0  TINFO  :  child 1 exiting
>> fcntl17     1  TFAIL  :  fcntl17.c:429: Alarm expired, deadlock not detected
>> fcntl17     0  TWARN  :  fcntl17.c:430: You may need to kill child processes by hand
>> fcntl17     2  TPASS  :  Block 1 PASSED
>> fcntl17     0  TINFO  :  Exit block 1
>> fcntl17     0  TWARN  :  tst_tmpdir.c:342: tst_rmdir: rmobj(/tmpdir/ltp-jRFBtBQhhx/LTP_fcn9Xy4hM) failed: unlink(/tmpdir/ltp-jRFBtBQhhx/LTP_fcn9Xy4hM) failed; errno=2: ENOENT
>> <<<execution_status>>>
>> initiation_status="ok"
>> duration=10 termination_type=exited termination_id=5 corefile=no
>> cutime=0 cstime=0
>> <<<test_end>>>
>> INFO: ltp-pan reported some tests FAIL
>> LTP Version: 20240129-167-gb592cdd0d
>>
>>
>> Steps used after installing latest ltp:
>>
>> $ mkdir /tmpdir
>> $ yum install nfs-utils  -y
>> $ echo "/media *(rw,no_root_squash,sync)" >/etc/exports
>> $ systemctl start nfs-server.service
>> $ mount -o rw,nfsvers=3 127.0.0.1:/media /tmpdir
>> $ cd /opt/ltp
>> $ ./runltp -d /tmpdir -s fcntl17
>>
>>
>>
>> This does not happen in 5.15.153 tag.
>>
>> Adding nfs people to the CC list
> 
> The reproducer uses NFSv3, but the bug report says NFSv4
> at the top.
> 
> I was able to reproduce this on my nfsd-5.15.y branch
> with NFSv3.
> 
> A bisect would be most helpful.

Interestingly, this same LTP fcntl17 test failure was reported to me 
internally some time back, in late 2022; at the time it was bisected to:

6930bcbfb6ce lockd: detect and reject lock arguments that overflow
	mainline v6.0-rc1
	stable v5.15.61

However, the failure was intermittent, and seemed very dependent on test 
system configuration; eventually it disappeared, so I put it down to 
test issues.


Harshit will continue to bisect this new case.

cheers,
calum.

> 
> 
>> Thanks,
>> Harshit
>>
>>
>>
>>
>>
>>> The whole patch series can be found in one patch at:
>>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.155-rc1.gz
>>> or in the git tree and branch at:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
>>> and the diffstat can be found below.
>>> thanks,
>>> greg k-h
> 
> --
> Chuck Lever
> 
> 




Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)