linux-kernel - Re: [PATCH] x86/tdx: Preserve shared bit on mprotect()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <h6cd5ag3t4t46hxnun427tuubnvwg542nydaxugs4i5p2knijk@ug3vsfpyvklk>
Date: Sat, 13 Apr 2024 00:23:33 +0300
From: "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
Cc: "tglx@...utronix.de" <tglx@...utronix.de>, 
	"mingo@...hat.com" <mingo@...hat.com>, "Hansen, Dave" <dave.hansen@...el.com>, 
	"bp@...en8.de" <bp@...en8.de>, "Cui, Dexuan" <decui@...rosoft.com>, 
	"Reshetova, Elena" <elena.reshetova@...el.com>, "x86@...nel.org" <x86@...nel.org>, 
	"seanjc@...gle.com" <seanjc@...gle.com>, "hpa@...or.com" <hpa@...or.com>, 
	"sathyanarayanan.kuppuswamy@...ux.intel.com" <sathyanarayanan.kuppuswamy@...ux.intel.com>, "thomas.lendacky@....com" <thomas.lendacky@....com>, 
	"cho@...rosoft.com" <cho@...rosoft.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/tdx: Preserve shared bit on mprotect()

On Fri, Apr 12, 2024 at 08:48:56PM +0000, Edgecombe, Rick P wrote:
> On Fri, 2024-04-12 at 22:12 +0300, Kirill A. Shutemov wrote:
> > The TDX guest platform takes one bit from the physical address to
> > indicate if the page is shared (accessible by VMM). This bit is not part
> > of the physical_mask and is not preserved during mprotect(). As a
> > result, the 'shared' bit is lost during mprotect() on shared mappings.
> > 
> > _COMMON_PAGE_CHG_MASK specifies which PTE bits need to be preserved
> > during modification. AMD includes 'sme_me_mask' in the define to
> > preserve the 'encrypt' bit.
> > 
> > To cover both Intel and AMD cases, include 'cc_mask' in
> > _COMMON_PAGE_CHG_MASK instead of 'sme_me_mask'.
> > 
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > Fixes: 41394e33f3a0 ("x86/tdx: Extend the confidential computing API to
> > support TDX guests")
> > Cc: Tom Lendacky <thomas.lendacky@....com>
> > Cc: Chris Oo <cho@...rosoft.com>
> > Cc: Dexuan Cui <decui@...rosoft.com>
> 
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@...el.com>
> 
> So does this mean there is shared memory mapped to userspace? Or is this a
> theoretical correctness thing?

Drivers can do this. Things like VFIO, I guess.

I think I should have credited Chris for reporting and testing the problem:

Reported-and-tested-by: Chris Oo <cho@...rosoft.com>

-- 
  Kiryl Shutsemau / Kirill A. Shutemov