linux-kernel - Re: [PATCH] crypto: ecc: remove checks in crypto_ecdh_shared_secret() and ecc_make_pub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zhjia82Bl+gaGHym@gondor.apana.org.au>
Date: Fri, 12 Apr 2024 15:27:39 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Roman Smirnov <r.smirnov@....ru>
Cc: "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, Sergey Shtylyov <s.shtylyov@....ru>
Subject: Re: [PATCH] crypto: ecc: remove checks in
 crypto_ecdh_shared_secret() and ecc_make_pub_key()

On Mon, Apr 01, 2024 at 03:16:23PM +0300, Roman Smirnov wrote:
> With the current state of the code, ecc_get_curve() cannot return
> NULL in crypto_ecdh_shared_secret() and ecc_make_pub_key(). This is
> conditioned by the fact that they are only called from ecdh_compute_value(),
> which implements the kpp_alg::{generate_public_key,compute_shared_secret}()
> methods. Also ecdh implements the kpp_alg::init() method, which is called
> before the other methods and sets ecdh_ctx::curve_id to a valid value.
> 
> Signed-off-by: Roman Smirnov <r.smirnov@....ru>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
> ---
>  crypto/ecc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt