linux-kernel - Re: [PATCH v2] crypto: algboss: remove NULL check in cryptomgr_schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZhjidWaJW7m8/6HQ@gondor.apana.org.au>
Date: Fri, 12 Apr 2024 15:27:49 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Roman Smirnov <r.smirnov@....ru>
Cc: "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, Sergey Shtylyov <s.shtylyov@....ru>,
	lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] crypto: algboss: remove NULL check in
 cryptomgr_schedule_probe()

On Mon, Apr 01, 2024 at 03:22:58PM +0300, Roman Smirnov wrote:
> The for loop will be executed at least once, so i > 0. If the loop
> is interrupted before i is incremented (e.g., when checking len for NULL),
> i will not be checked.
> 
> Found by Linux Verification Center (linuxtesting.org) with Svace.
> 
> Signed-off-by: Roman Smirnov <r.smirnov@....ru>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
> ---
>  crypto/algboss.c | 3 ---
>  1 file changed, 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt