linux-kernel - Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 12 Apr 2024 11:00:35 +0000
From: Olivia Wen (温倩苓) <Olivia.Wen@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "mathieu.poirier@...aro.org"
	<mathieu.poirier@...aro.org>, "andersson@...nel.org" <andersson@...nel.org>,
	"krzk@...nel.org" <krzk@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Jason-ch Chen (陳建豪)
	<Jason-ch.Chen@...iatek.com>, Yaya Chang (張雅清)
	<Yaya.Chang@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	Teddy Chen (陳乾元) <Teddy.Chen@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>,
	TingHan Shen (沈廷翰) <TingHan.Shen@...iatek.com>
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188
 dual-core SCP

Hi Krzysztof,

Thanks for the reviews.

On Thu, 2024-04-11 at 08:06 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 11/04/2024 05:37, olivia.wen wrote:
> > Under different applications, the MT8188 SCP can be used as single-
> core
> > or dual-core.
> > 
> > Signed-off-by: olivia.wen <olivia.wen@...iatek.com>
> 
> Are you sure you use full name, not email login as name?
> 

Thanks for the reminder. I have made changes.

> > ---
> >  Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git
> a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > index 507f98f..7e7b567 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > @@ -22,7 +22,7 @@ properties:
> >        - mediatek,mt8192-scp
> >        - mediatek,mt8195-scp
> >        - mediatek,mt8195-scp-dual
> > -
> > +      - mediatek,mt8188-scp-dual
> 
> Missing blank line, misordered.
> 

It will be corrected in the next version.

> >    reg:
> >      description:
> >        Should contain the address ranges for memory regions SRAM,
> CFG, and,
> > @@ -195,6 +195,7 @@ allOf:
> >          compatible:
> >            enum:
> >              - mediatek,mt8195-scp-dual
> > +            - mediatek,mt8188-scp-dual
> 
> Again, keep the order.
> 

It will be corrected in the next version.

> Best regards,a
> Krzysztof
> 
> 

Best regards,
Olivia