[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fed4ef723f15991c2445de957a10420e6a1c0101.camel@mediatek.com>
Date: Fri, 12 Apr 2024 11:01:38 +0000
From: Olivia Wen (温倩苓) <Olivia.Wen@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "mathieu.poirier@...aro.org"
<mathieu.poirier@...aro.org>, "angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>, "andersson@...nel.org"
<andersson@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Jason-ch Chen (陳建豪)
<Jason-ch.Chen@...iatek.com>, Yaya Chang (張雅清)
<Yaya.Chang@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>,
Teddy Chen (陳乾元) <Teddy.Chen@...iatek.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
TingHan Shen (沈廷翰) <TingHan.Shen@...iatek.com>
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188
dual-core SCP
Hi AngeloGioacchino,
On Thu, 2024-04-11 at 09:39 +0200, AngeloGioacchino Del Regno wrote:
> Il 11/04/24 09:34, AngeloGioacchino Del Regno ha scritto:
> > Il 11/04/24 05:37, olivia.wen ha scritto:
> > > Under different applications, the MT8188 SCP can be used as
> > > single-core
> > > or dual-core.
> > >
> > > Signed-off-by: olivia.wen <olivia.wen@...iatek.com>
> > > ---
> > > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3
> > > ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > index 507f98f..7e7b567 100644
> > > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > @@ -22,7 +22,7 @@ properties:
> > > - mediatek,mt8192-scp
> > > - mediatek,mt8195-scp
> > > - mediatek,mt8195-scp-dual
> > > -
> >
> > Don't remove the blank line, it's there for readability.
> >
> > > + - mediatek,mt8188-scp-dual
>
> Ah, sorry, one more comment. Please, keep the entries ordered by
> name.
> 8188 goes before 8195.
>
> >
> > After addressing that comment,
> >
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@...labora.com>
> >
> > > reg:
> > > description:
> > > Should contain the address ranges for memory regions
> > > SRAM, CFG, and,
> > > @@ -195,6 +195,7 @@ allOf:
> > > compatible:
> > > enum:
> > > - mediatek,mt8195-scp-dual
> > > + - mediatek,mt8188-scp-dual
>
> same here.
>
> > > then:
> > > properties:
> > > reg:
> >
> >
>
Thanks for the reviews.
It will be corrected in the next version.
Best regards,
Olivia
Powered by blists - more mailing lists