linux-kernel - Re: [PATCH 2/2] remoteproc: mediatek: Support MT8188 SCP core 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa64c07569f249d52252689f47db2a6a9bfc2666.camel@mediatek.com>
Date: Fri, 12 Apr 2024 11:06:03 +0000
From: Olivia Wen (温倩苓) <Olivia.Wen@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "mathieu.poirier@...aro.org"
	<mathieu.poirier@...aro.org>, "andersson@...nel.org" <andersson@...nel.org>,
	"krzk@...nel.org" <krzk@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Jason-ch Chen (陳建豪)
	<Jason-ch.Chen@...iatek.com>, Yaya Chang (張雅清)
	<Yaya.Chang@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	Teddy Chen (陳乾元) <Teddy.Chen@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>,
	TingHan Shen (沈廷翰) <TingHan.Shen@...iatek.com>
Subject: Re: [PATCH 2/2] remoteproc: mediatek: Support MT8188 SCP core 1

Hi Krzysztof,

On Thu, 2024-04-11 at 08:07 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 11/04/2024 05:37, olivia.wen wrote:
> > +};
> > +
> >  static const struct of_device_id mtk_scp_of_match[] = {
> >  { .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data },
> >  { .compatible = "mediatek,mt8186-scp", .data = &mt8186_of_data },
> > @@ -1323,6 +1362,7 @@ static const struct of_device_id
> mtk_scp_of_match[] = {
> >  { .compatible = "mediatek,mt8192-scp", .data = &mt8192_of_data },
> >  { .compatible = "mediatek,mt8195-scp", .data = &mt8195_of_data },
> >  { .compatible = "mediatek,mt8195-scp-dual", .data =
> &mt8195_of_data_cores },
> > +{ .compatible = "mediatek,mt8188-scp-dual", .data =
> &mt8188_of_data_cores },
> 
> Why do you add new entries to the end? Look at the list first.
> 
> Best regards,
> Krzysztof

Thanks for the reviews.
I will change the order as follows.
> +{ .compatible = "mediatek,mt8188-scp-dual", .data =
&mt8188_of_data_cores },
>  { .compatible = "mediatek,mt8195-scp-dual", .data =
&mt8195_of_data_cores },

Best regards,
Olivia