[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZhpC3lLD-BHqJEZz@ishi>
Date: Sat, 13 Apr 2024 04:31:26 -0400
From: William Breathitt Gray <wbg@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
Andy Shevchenko <andy@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 1/1] gpio: sch: Switch to memory mapped IO accessors
On Wed, Apr 10, 2024 at 10:21:02AM +0300, Andy Shevchenko wrote:
> Convert driver to use memory mapped IO accessors.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>
Acked-by: William Breathitt Gray <wbg@...nel.org>
A minor suggestion below, but I find this patch accepted as-is.
> static int sch_gpio_probe(struct platform_device *pdev)
> {
> + struct device *dev = &pdev->dev;
In general I think this is a good variable to define to simplify all the
&pdev->dev appearing throughout this callback, but I'd rather have seen
it as its own patch so we could change all the other uses of &pdev->dev
at once without distracting from the memory-mapped I/O change of this
particular patch. Not really necessary, but maybe at some point in the
future a follow-up patch doing such a cleanup would be nice.
William Breathitt Gray
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists