linux-kernel - Re: [PATCH v1 1/1] gpio: sch: Switch to memory mapped IO accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zh0mFrrmrO1zNmoN@smile.fi.intel.com>
Date: Mon, 15 Apr 2024 16:05:26 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: William Breathitt Gray <wbg@...nel.org>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 1/1] gpio: sch: Switch to memory mapped IO accessors

On Sat, Apr 13, 2024 at 04:31:26AM -0400, William Breathitt Gray wrote:
> On Wed, Apr 10, 2024 at 10:21:02AM +0300, Andy Shevchenko wrote:
> > Convert driver to use memory mapped IO accessors.
> > 
> > Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> Acked-by: William Breathitt Gray <wbg@...nel.org>

Pushed to my review and testing queue, thank you!

> A minor suggestion below, but I find this patch accepted as-is.
> 
> >  static int sch_gpio_probe(struct platform_device *pdev)
> >  {
> > +	struct device *dev = &pdev->dev;
> 
> In general I think this is a good variable to define to simplify all the
> &pdev->dev appearing throughout this callback, but I'd rather have seen
> it as its own patch so we could change all the other uses of &pdev->dev
> at once without distracting from the memory-mapped I/O change of this
> particular patch. Not really necessary, but maybe at some point in the
> future a follow-up patch doing such a cleanup would be nice.

I avoid making unneeded  churn on a line I have updated in this patch.
That's why I introduced the local variable proactively. Yet, I can do
another patch to clean up the driver based on the existence of this var.

-- 
With Best Regards,
Andy Shevchenko