[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dnh4yiajjqcxcq7xjvj35quda7yrf7tubp2l2ktsaf4zgzai4n@xdefxkk76yyg>
Date: Sat, 13 Apr 2024 16:35:06 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Heiko Stübner <heiko@...ech.de>
Cc: Dragan Simic <dsimic@...jaro.org>, linux-i2c@...r.kernel.org,
Andi Shyti <andi.shyti@...nel.org>, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts
> Also we're talking about two lines of code, I wouldn't call that bloat ;-)
With this patch, yes. But once you allow debug code, it is hard to draw
a line which debug is still okay and which is too fine-grained. And then
you end up with a lot. Over the years, I developed the tendency to try
to have less but meaningful error printouts. But I don't enforce it
strictly because it is too much bike-shedding discussion.
In case of this error printout here, it is just wrong. But, see, it also
came from this tendency I don't like to have printouts for every error.
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists