linux-kernel - Re: [PATCH v2 15/15] ARM: dts: bcm2711: add bcm2711-dma node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a63aa94-e8b4-4282-9622-7c3a7eed1c99@linaro.org>
Date: Sun, 14 Apr 2024 08:26:37 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Andrea della Porta <andrea.porta@...e.com>, Vinod Koul
 <vkoul@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>, Ray Jui
 <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Saenz Julienne <nsaenz@...nel.org>,
 dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, dave.stevenson@...pberrypi.com
Cc: Stefan Wahren <stefan.wahren@...e.com>
Subject: Re: [PATCH v2 15/15] ARM: dts: bcm2711: add bcm2711-dma node

On 12/03/2024 10:12, Andrea della Porta wrote:
> BCM2711 has 4 DMA channels with a 40-bit address range, allowing them
> to access the full 4GB of memory on a Pi 4. Adding a new node to make
> use of the DMA channels capable of 40 bit addressing.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@...e.com>
> Signed-off-by: Andrea della Porta <andrea.porta@...e.com>
> ---
>  arch/arm/boot/dts/broadcom/bcm2711.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711.dtsi b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> index 22c7f1561344..d98e3cf0c569 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> @@ -552,6 +552,22 @@ scb {
>  		ranges = <0x0 0x7c000000  0x0 0xfc000000  0x03800000>,
>  			 <0x6 0x00000000  0x6 0x00000000  0x40000000>;
>  
> +		dma40: dma-controller@...07b00 {
> +			compatible = "brcm,bcm2711-dma";
> +			reg = <0x0 0x7e007b00 0x400>;
> +			interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>, /* dma4 11 */
> +				     <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>, /* dma4 12 */
> +				     <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>, /* dma4 13 */
> +				     <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>; /* dma4 14 */
> +			interrupt-names = "dma11",
> +					  "dma12",
> +					  "dma13",
> +					  "dma14";
> +			#dma-cells = <1>;
> +			/* The VPU firmware uses DMA channel 11 for VCHIQ */
> +			brcm,dma-channel-mask = <0x7000>;

Isn't one of your commits saying - this property is replaced?

Best regards,
Krzysztof