linux-kernel - Re: [PATCH v3] ACPI: CPPC: Fix access width used for PCC registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6081eadb-0879-4a7f-93a2-18a8132c0f83@linux.microsoft.com>
Date: Mon, 15 Apr 2024 09:59:23 -0700
From: Jarred White <jarredwhite@...ux.microsoft.com>
To: Vanshidhar Konda <vanshikonda@...amperecomputing.com>,
 Easwar Hariharan <eahariha@...ux.microsoft.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
 linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
 "5 . 15+" <stable@...r.kernel.org>
Subject: Re: [PATCH v3] ACPI: CPPC: Fix access width used for PCC registers

On 4/11/2024 4:18 PM, Vanshidhar Konda wrote:
> commit 2f4a4d63a193be6fd530d180bb13c3592052904c modified
> cpc_read/cpc_write to use access_width to read CPC registers. For PCC
> registers the access width field in the ACPI register macro specifies
> the PCC subspace id. For non-zero PCC subspace id the access width is
> incorrectly treated as access width. This causes errors when reading
> from PCC registers in the CPPC driver.
> 
> For PCC registers base the size of read/write on the bit width field.
> The debug message in cpc_read/cpc_write is updated to print relevant
> information for the address space type used to read the register.
> 
> Signed-off-by: Vanshidhar Konda <vanshikonda@...amperecomputing.com>
> Tested-by: Jarred White <jarredwhite@...ux.microsoft.com>
> Reviewed-by: Jarred White <jarredwhite@...ux.microsoft.com>
> Reviewed-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
> Cc: 5.15+ <stable@...r.kernel.org> # 5.15+

Hi Vanshi,

v3 changes are good. Thanks again for catching this!

Thanks,
Jarred