linux-kernel - Re: [PATCH v2 26/30] dmaengine: idxd: Assign parent for event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 15 Apr 2024 12:05:13 -0700
From: Fenghua Yu <fenghua.yu@...el.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>, Mark Rutland
	<mark.rutland@....com>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar
	<mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, Will Deacon
	<will@...nel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <gregkh@...uxfoundation.org>
CC: <linuxarm@...wei.com>, Shaokun Zhang <zhangshaokun@...ilicon.com>, "Yicong
 Yang" <yangyicong@...ilicon.com>, Jiucheng Xu <jiucheng.xu@...ogic.com>,
	Khuong Dinh <khuong@...amperecomputing.com>, Atish Patra
	<atishp@...shpatra.org>, Anup Patel <anup@...infault.org>, Andy Gross
	<agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>, Frank Li
	<Frank.li@....com>, Shuai Xue <xueshuai@...ux.alibaba.com>, Vineet Gupta
	<vgupta@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Dave Jiang
	<dave.jiang@...el.com>, Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
	<linux-fpga@...r.kernel.org>, Suzuki K Poulose <suzuki.poulose@....com>,
	Liang Kan <kan.liang@...ux.intel.com>
Subject: Re: [PATCH v2 26/30] dmaengine: idxd: Assign parent for event_source
 device

Hi, Jonathan,


On 4/12/24 09:10, Jonathan Cameron wrote:
> Currently the PMU device appears directly under /sys/devices/
> Only root busses should appear there, so instead assign the pmu->dev
           s/busses/buses/

> parent to be the iDXD PCI Device.
                   s/iDXD/IDXD/
> 
> Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/
> Cc: Fenghua Yu <fenghua.yu@...el.com>
> Cc: Dave Jiang <dave.jiang@...el.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Other than the typos,

Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>

> ---
>   drivers/dma/idxd/perfmon.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/idxd/perfmon.c b/drivers/dma/idxd/perfmon.c
> index fdda6d604262..fbb586eed0b3 100644
> --- a/drivers/dma/idxd/perfmon.c
> +++ b/drivers/dma/idxd/perfmon.c
> @@ -477,6 +477,7 @@ static void idxd_pmu_init(struct idxd_pmu *idxd_pmu)
>   	}
>   
>   	idxd_pmu->pmu.name		= idxd_pmu->name;
> +	idxd_pmu->pmu.parent		= &idxd_pmu->idxd->pdev->dev;
>   	idxd_pmu->pmu.attr_groups	= perfmon_attr_groups;
>   	idxd_pmu->pmu.task_ctx_nr	= perf_invalid_context;
>   	idxd_pmu->pmu.event_init	= perfmon_pmu_event_init;

Thanks.

-Fenghua