linux-kernel - Re: [PATCH v2 16/30] perf/arm_pmu: Assign parents for event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 Apr 2024 10:36:49 +0100
From: Suzuki K Poulose <suzuki.poulose@....com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Mark Rutland <mark.rutland@....com>, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, gregkh@...uxfoundation.org
Cc: linuxarm@...wei.com, Shaokun Zhang <zhangshaokun@...ilicon.com>,
 Yicong Yang <yangyicong@...ilicon.com>, Jiucheng Xu
 <jiucheng.xu@...ogic.com>, Khuong Dinh <khuong@...amperecomputing.com>,
 Atish Patra <atishp@...shpatra.org>, Anup Patel <anup@...infault.org>,
 Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Frank Li <Frank.li@....com>, Shuai Xue <xueshuai@...ux.alibaba.com>,
 Vineet Gupta <vgupta@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Fenghua Yu <fenghua.yu@...el.com>, Dave Jiang <dave.jiang@...el.com>,
 Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
 linux-fpga@...r.kernel.org, Liang Kan <kan.liang@...ux.intel.com>
Subject: Re: [PATCH v2 16/30] perf/arm_pmu: Assign parents for event_source
 devices

On 12/04/2024 17:10, Jonathan Cameron wrote:
> Currently the PMU device appears directly under /sys/devices/
> Only root busses should appear there, so instead assign the pmu->dev
> parent to be the platform device.
> 
> Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> ---
>   drivers/perf/arm_pmu_platform.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/perf/arm_pmu_platform.c b/drivers/perf/arm_pmu_platform.c
> index 3596db36cbff..4b1a9a92ea11 100644
> --- a/drivers/perf/arm_pmu_platform.c
> +++ b/drivers/perf/arm_pmu_platform.c
> @@ -196,6 +196,7 @@ int arm_pmu_device_probe(struct platform_device *pdev,
>   	if (!pmu)
>   		return -ENOMEM;
>   
> +	pmu->pmu.parent = &pdev->dev;
>   	pmu->plat_device = pdev;
>   
>   	ret = pmu_parse_irqs(pmu);


Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>