linux-kernel - Re: [PATCH v2 30/30] hwtracing: hisi_ptt: Assign parent for event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0293b97e-8f21-4d0e-966e-1a601bc923b2@arm.com>
Date: Tue, 16 Apr 2024 10:38:06 +0100
From: Suzuki K Poulose <suzuki.poulose@....com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Mark Rutland <mark.rutland@....com>, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, gregkh@...uxfoundation.org
Cc: linuxarm@...wei.com, Shaokun Zhang <zhangshaokun@...ilicon.com>,
 Yicong Yang <yangyicong@...ilicon.com>, Jiucheng Xu
 <jiucheng.xu@...ogic.com>, Khuong Dinh <khuong@...amperecomputing.com>,
 Atish Patra <atishp@...shpatra.org>, Anup Patel <anup@...infault.org>,
 Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Frank Li <Frank.li@....com>, Shuai Xue <xueshuai@...ux.alibaba.com>,
 Vineet Gupta <vgupta@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Fenghua Yu <fenghua.yu@...el.com>, Dave Jiang <dave.jiang@...el.com>,
 Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
 linux-fpga@...r.kernel.org, Liang Kan <kan.liang@...ux.intel.com>
Subject: Re: [PATCH v2 30/30] hwtracing: hisi_ptt: Assign parent for
 event_source device

On 12/04/2024 17:10, Jonathan Cameron wrote:
> Currently the PMU device appears directly under /sys/devices/
> Only root busses should appear there, so instead assign the pmu->dev
> parent to be the PCI device.
> 
> Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/
> Cc: Suzuki K Poulose <suzuki.poulose@....com>
> Reviewed-by: Yicong Yang <yangyicong@...ilicon.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> ---
>   drivers/hwtracing/ptt/hisi_ptt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c
> index 4bf04a977840..3090479a2979 100644
> --- a/drivers/hwtracing/ptt/hisi_ptt.c
> +++ b/drivers/hwtracing/ptt/hisi_ptt.c
> @@ -1221,6 +1221,7 @@ static int hisi_ptt_register_pmu(struct hisi_ptt *hisi_ptt)
>   
>   	hisi_ptt->hisi_ptt_pmu = (struct pmu) {
>   		.module		= THIS_MODULE,
> +		.parent         = &hisi_ptt->pdev->dev,
>   		.capabilities	= PERF_PMU_CAP_EXCLUSIVE | PERF_PMU_CAP_NO_EXCLUDE,
>   		.task_ctx_nr	= perf_sw_context,
>   		.attr_groups	= hisi_ptt_pmu_groups,


Acked-by: Suzuki K Poulose <suzuki.poulose@....com>