linux-kernel - Re: [PATCH v2 3/5] mmc: sdhci-sprd: Constify struct sdhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1cc8e549-11a7-463a-ad74-527ccacb744a@linux.alibaba.com>
Date: Mon, 15 Apr 2024 09:45:37 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Adrian Hunter <adrian.hunter@...el.com>,
 Angelo Dureghello <adureghello@...libre.com>,
 Ulf Hansson <ulf.hansson@...aro.org>, Vignesh Raghavendra <vigneshr@...com>,
 Orson Zhai <orsonzhai@...il.com>, Chunyan Zhang <zhang.lyra@...il.com>,
 Ben Dooks <ben-linux@...ff.org>, Jaehoon Chung <jh80.chung@...sung.com>
Cc: linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] mmc: sdhci-sprd: Constify struct sdhci_ops



On 2024/4/14 22:07, Krzysztof Kozlowski wrote:
> The local struct sdhci_ops can be made const for code safety.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

> ---
>   drivers/mmc/host/sdhci-sprd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 685b1c648901..8776f4287119 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -439,7 +439,7 @@ static void sdhci_sprd_set_power(struct sdhci_host *host, unsigned char mode,
>   	}
>   }
>   
> -static struct sdhci_ops sdhci_sprd_ops = {
> +static const struct sdhci_ops sdhci_sprd_ops = {
>   	.read_l = sdhci_sprd_readl,
>   	.write_l = sdhci_sprd_writel,
>   	.write_w = sdhci_sprd_writew,
>