[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240415015029.3699844-1-yebin10@huawei.com>
Date: Mon, 15 Apr 2024 09:50:29 +0800
From: Ye Bin <yebin10@...wei.com>
To: <alex.williamson@...hat.com>, <kevin.tian@...el.com>,
<reinette.chatre@...el.com>, <tglx@...utronix.de>, <brauner@...nel.org>,
<yebin10@...wei.com>, <kvm@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>
Subject: [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable()
If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.
Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
Signed-off-by: Ye Bin <yebin10@...wei.com>
---
drivers/vfio/pci/vfio_pci_intrs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
index fb5392b749ff..e80c5d75b541 100644
--- a/drivers/vfio/pci/vfio_pci_intrs.c
+++ b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -277,8 +277,10 @@ static int vfio_intx_enable(struct vfio_pci_core_device *vdev,
return -ENOMEM;
ctx = vfio_irq_ctx_alloc(vdev, 0);
- if (!ctx)
+ if (!ctx) {
+ kfree(name);
return -ENOMEM;
+ }
ctx->name = name;
ctx->trigger = trigger;
--
2.31.1
Powered by blists - more mailing lists