linux-kernel - Re: [PATCH] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <637f9185-3fde-48c4-9a47-30987c8dd5a2@moroto.mountain>
Date: Mon, 15 Apr 2024 14:08:37 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Zeng Heng <zengheng4@...wei.com>
Cc: linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
	xiexiuqi@...wei.com, linux-gpio@...r.kernel.org,
	weiyongjun1@...wei.com, liwei391@...wei.com
Subject: Re: [PATCH] pinctrl: devicetree: fix refcount leak in
 pinctrl_dt_to_map()

On Mon, Apr 15, 2024 at 06:53:28PM +0800, Zeng Heng wrote:
> If we fail to allocate propname buffer, we need to drop the reference
> count we just took. Because the pinctrl_dt_free_maps() includes the
> droping operation, here we call it directly.
> 
> Fixes: 91d5c5060ee2 ("pinctrl: devicetree: fix null pointer dereferencing in pinctrl_dt_to_map")
> Suggested-by: Dan Carpenter <dan.carpenter@...aro.org>
> Signed-off-by: Zeng Heng <zengheng4@...wei.com>
> ---

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter