linux-kernel - Re: [PATCH v3] irqchip/gic-v3-its: Fix double free on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1a38236-82fb-40e3-a7eb-bac913ba8f0f@web.de>
Date: Mon, 15 Apr 2024 15:06:54 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Guanrui Huang <guanrui.huang@...ux.alibaba.com>,
 linux-arm-kernel@...ts.infradead.org, kernel-janitors@...r.kernel.org,
 Marc Zyngier <maz@...nel.org>, Zenghui Yu <yuzenghui@...wei.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Shannon Zhao <shannon.zhao@...ux.alibaba.com>,
 Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v3] irqchip/gic-v3-its: Fix double free on error

> In its_vpe_irq_domain_alloc, when its_vpe_init() returns an error
> with i > 0, its_vpe_irq_domain_free may free bitmap and vprop_page,
> and then there is a double free in its_vpe_irq_domain_alloc.
>
> Fix it by calling its_vpe_irq_domain_free directly, bitmap and
> vprop_page will be freed in this function.

I find this change description improvable.

Would you like to add the tag “Fixes” accordingly?


…
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -4521,8 +4521,6 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq
>  	struct page *vprop_page;
>  	int base, nr_ids, i, err = 0;
>
> -	BUG_ON(!vm);
…

Please improve the patch granularity.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc4#n81

Regards,
Markus