linux-kernel - Re: [PATCH v5 4/5] dt-bindings: iio: adc: ad7192: Add AD7194 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <105bd25b-e5ea-4649-b9b2-2547e94b103e@gmail.com>
Date: Mon, 15 Apr 2024 16:08:00 +0300
From: Alisa-Dariana Roman <alisadariana@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 michael.hennerich@...log.com, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: alexandru.tachici@...log.com, lars@...afoo.de, jic23@...nel.org,
 robh@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 lgirdwood@...il.com, broonie@...nel.org, andy@...nel.org,
 nuno.sa@...log.com, marcelo.schmitt@...log.com, bigunclemax@...il.com,
 dlechner@...libre.com, okan.sahin@...log.com, fr0st61te@...il.com,
 alisa.roman@...log.com, marcus.folkesson@...il.com, schnelle@...ux.ibm.com,
 liambeguin@...il.com
Subject: Re: [PATCH v5 4/5] dt-bindings: iio: adc: ad7192: Add AD7194 support

On 14.04.2024 00:19, Krzysztof Kozlowski wrote:
> On 13/04/2024 17:11, Alisa-Dariana Roman wrote:
>> Unlike the other AD719Xs, AD7194 has configurable differential
>> channels. The user can dynamically configure them in the devicetree.
>>
>> Also add an example for AD7194 devicetree.
>>
>> Signed-off-by: Alisa-Dariana Roman <alisa.roman@...log.com>
>> ---
>>   .../bindings/iio/adc/adi,ad7192.yaml          | 74 +++++++++++++++++++
>>   1 file changed, 74 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
>> index ba506af3b73e..855f0a2d7d75 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml

..

> 
>> +  "^channel@[0-9]+$":
> 
> Why restricting the pattern? If you have 256 channels, how are you going
> to encode it?

Hi Krzysztof,

Thank you for your feedback! I applied the rest, but as for this one 
isn't channel@1 -> channel@256 encoding sufficient?

Kind regards,
Alisa-Dariana Roman