linux-kernel - Re: [PATCH v5 5/5] iio: adc: ad7192: Add AD7194 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 15 Apr 2024 16:31:45 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Alisa-Dariana Roman <alisadariana@...il.com>, michael.hennerich@...log.com, 
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, alexandru.tachici@...log.com, lars@...afoo.de, 
	jic23@...nel.org, robh@...nel.org, krzysztof.kozlowski+dt@...aro.org, 
	conor+dt@...nel.org, lgirdwood@...il.com, broonie@...nel.org, andy@...nel.org, 
	nuno.sa@...log.com, marcelo.schmitt@...log.com, bigunclemax@...il.com, 
	okan.sahin@...log.com, fr0st61te@...il.com, alisa.roman@...log.com, 
	marcus.folkesson@...il.com, schnelle@...ux.ibm.com, liambeguin@...il.com
Subject: Re: [PATCH v5 5/5] iio: adc: ad7192: Add AD7194 support

On Sat, Apr 13, 2024 at 11:05 PM David Lechner <dlechner@...libre.com> wrote:
> On Sat, Apr 13, 2024 at 10:13 AM Alisa-Dariana Roman
> <alisadariana@...il.com> wrote:

..

> > +static int ad7192_parse_channels(struct iio_dev *indio_dev)
>
> Better name might be ad7194_parse_channels() or
> ad7192_parse_ad7194_channels() since this is specific to the ad7194
> chip.

Quite unlikely we have the same chip to be supported by somewhere
else, so I would just name it simpler, i.e.

ad7194_parse_channels()

-- 
With Best Regards,
Andy Shevchenko