linux-kernel - Re: [PATCH v3 2/2] power: supply: ltc3350-charger: Add driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cda9f2ff-d13f-4421-ad10-72ab29fa0024@topic.nl>
Date: Mon, 15 Apr 2024 15:08:01 +0200
From: Mike Looijmans <mike.looijmans@...ic.nl>
To: Sebastian Reichel <sebastian.reichel@...labora.com>
CC: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Nícolas F. R. A. Prado <nfraprado@...labora.com>
Subject: Re: [PATCH v3 2/2] power: supply: ltc3350-charger: Add driver

On 14-04-2024 19:29, Sebastian Reichel wrote:
> [+cc Nicolas]
>
> Hello Mike,
>
> On Fri, Apr 12, 2024 at 08:53:58AM +0200, Mike Looijmans wrote:
>>> please share output of
>>> ./tools/testing/selftests/power_supply/test_power_supply_properties.sh
>>> below the fold with your next submission. It's useful for verifying,
>>> that you got the unit scaling correct for the standard properties :)
>> Will do. Did a quick run on the driver as it is now, that yields the
>> following output:
>>
>> (Any thoughts on the "arithmetic syntax error" messages?)
> The script contains some bash specific shell extensions and should
> use /bin/bash instead of /bin/sh in the shebang. Just call it with
> /bin/bash ./tools/testing/... and you should get rid of them :)

Yeah, installing full bash (instead of busybox ash) on the board fixes 
these messages.

>
> Nicolas, do you want to send a fix for that to Shuah with Reported-by
> from Mike?
>
> [...]
>
>> # Reported: '1' ()
>> ok 6 ltc3350.sysfs.online
> [...]
>
>> # Reported: '711600' uA (711.6 mA)
>> ok 24 ltc3350.sysfs.current_now
> So it's full, but still getting charged with 0.7 Amps at ~23V
> (i.e. 16W)? That seems quite high.

The "current" is also feeding the system, not just the capacitors. 
(panel backlight being the main consumer)

I modeled the current into the caps as 
POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT but in retrospect, that may 
not be the right place.  Maybe that should be the "CURRENT_NOW" of the 
battery component?

..

-- 
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@...ic.nl
W: www.topic.nl