linux-kernel - Re: [PATCH v6 5/5] virt: vmgenid: add support for devicetree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fe62eb1-8ad5-4ced-9349-258cee9de663@kernel.org>
Date: Wed, 17 Apr 2024 18:02:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Jason A. Donenfeld" <Jason@...c4.com>, sudanl@...zon.com,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: tytso@....edu, olivia@...enic.com, herbert@...dor.apana.org.au,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, graf@...zon.de, xmarcalx@...zon.co.uk,
 dwmw@...zon.co.uk, Alexander Graf <graf@...zon.com>,
 Babis Chalios <bchalios@...zon.es>
Subject: Re: [PATCH v6 5/5] virt: vmgenid: add support for devicetree bindings

On 17/04/2024 17:16, Jason A. Donenfeld wrote:

>> +static irqreturn_t
>> +vmgenid_of_irq_handler(int __always_unused irq, void *dev)
>> +{
>> +       vmgenid_notify(dev);
>> +
>> +       return IRQ_HANDLED;
>> +}
> 
> Is there a reason the of code isn't conditional on CONFIG_OF? I'm not
> super familiar with these drivers, but this seems like it would be a
> thing to do, and then we could do `depends on OF || ACPI` in the
> Kconfig.
> 

Usually we do not recommend hiding code behind !CONFIG_OF because this
limits possible usage on ACPI systems via PRP0001. Not sure if it is
applicable here, because there is already ACPI matching.

I would suggest choose whatever makes code simpler... Or just mark some
pieces with __maybe_unused if they are really not used? That would avoid
ifdeffery.

Best regards,
Krzysztof