linux-kernel - Re: [PATCH v6 5/5] virt: vmgenid: add support for devicetree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHmME9rtwMEBL-F5mQLuQREr=TqpuYChYn1rxpfGYqX11x-Efg@mail.gmail.com>
Date: Wed, 17 Apr 2024 18:11:05 +0200
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: sudanl@...zon.com, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, tytso@....edu, 
	olivia@...enic.com, herbert@...dor.apana.org.au, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, linux-crypto@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, graf@...zon.de, 
	xmarcalx@...zon.co.uk, dwmw@...zon.co.uk, Alexander Graf <graf@...zon.com>, 
	Babis Chalios <bchalios@...zon.es>
Subject: Re: [PATCH v6 5/5] virt: vmgenid: add support for devicetree bindings

Hi Krzysztof,

On Wed, Apr 17, 2024 at 6:02 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> Usually we do not recommend hiding code behind !CONFIG_OF because this
> limits possible usage on ACPI systems via PRP0001. Not sure if it is
> applicable here, because there is already ACPI matching.
>
> I would suggest choose whatever makes code simpler... Or just mark some
> pieces with __maybe_unused if they are really not used? That would avoid
> ifdeffery.

Interesting about PRP0001. Alright. It looks like I can't quite do
without ifdefs because the code dereferences ->handle in a acpi_device
struct, but I can minimize it all to just a single ifdef.

Jason