linux-kernel - Re: [PATCH] platform/x86: asus-wmi: add support for vivobook fan profiles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 17 Apr 2024 09:28:44 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Mohamed Ghanmi <mohamed.ghanmi@...com.tn>
cc: "Luke D. Jones" <luke@...nes.dev>, Hans de Goede <hdegoede@...hat.com>, 
    corentin.chary@...il.com, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wmi: add support for vivobook fan
 profiles

On Tue, 16 Apr 2024, Mohamed Ghanmi wrote:

> On Tue, Apr 16, 2024 at 03:51:03PM +0300, Ilpo Järvinen wrote:
> > On Sun, 14 Apr 2024, Luke D. Jones wrote:
> > 
> > > From: Mohamed Ghanmi <mohamed.ghanmi@...com.tn>
> > > 
> > > Add support for vivobook fan profiles wmi call on the ASUS VIVOBOOK
> > > to adjust power limits.
> > > 
> > > These fan profiles have a different device id than the ROG series.


> > > and different order.
> > 
> > Fix grammar.
> 
> my grammar is not the greatest so i'm finding it hard to know what is
> the error you're referring to but I think that 'add'
> should become 'adds' ?

That's not what I was referring to, you've a dangling/broken "sentence"
right in front of my reply: 

"and different order."

Please fix that. Perhaps you just want to remove the stop (".") from 
the previous sentence to join the sentences together?

-- 
 i.