linux-kernel - Re: [PATCH] bpf: btf: include linux/types.h for u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANXV_XwGhdV7v05Xjjp-g9yW4E0FjA=84M8jZ6bcf7yuooDkig@mail.gmail.com>
Date: Wed, 17 Apr 2024 09:26:03 +0300
From: Dmitrii Bundin <dmitrii.bundin.a@...il.com>
To: Daniel Borkmann <daniel@...earbox.net>
Cc: Jiri Olsa <olsajiri@...il.com>, linux-kernel@...r.kernel.org, bpf@...r.kernel.org, 
	haoluo@...gle.com, sdf@...gle.com, kpsingh@...nel.org, 
	john.fastabend@...il.com, yonghong.song@...ux.dev, song@...nel.org, 
	eddyz87@...il.com, andrii@...nel.org, ast@...nel.org, martin.lau@...ux.dev, 
	khazhy@...omium.org, vmalik@...hat.com, ndesaulniers@...gle.com, 
	ncopa@...inelinux.org, dxu@...uu.xyz
Subject: Re: [PATCH] bpf: btf: include linux/types.h for u32

On Tue, Apr 16, 2024 at 5:47 PM Daniel Borkmann <daniel@...earbox.net> wrote:
> Please add the error description as motivation aka "why" into the commit
> description, otherwise it's not really obvious looking at it at a later
> point in time why the include was needed.

Doesn't the comment /* for u32 */ following the include explain the
purpose? I thought the include was actually missing since relying on
indirect declaration of u32 is relatively fragile.